linux-kernel - Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 12:20:54 -0700
From:   Tyrel Datwyler <tyreld@...ux.ibm.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>, mpe@...erman.id.au,
        benh@...nel.crashing.org, paulus@...ba.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

On 9/7/20 1:39 AM, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>

Acked-by: Tyrel Datwyler <tyreld@...ux.ibm.com>

> ---
>  drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index ea7c8930592d..70daa0605082 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
>  	if (IS_ERR(vhost->work_thread)) {
>  		dev_err(dev, "Couldn't create kernel thread: %ld\n",
>  			PTR_ERR(vhost->work_thread));
> +		rc = PTR_ERR(vhost->work_thread);
>  		goto free_host_mem;
>  	}
>  
>