linux-kernel - [PATCH 2/2] w1: Remove pointless debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  9 Sep 2020 20:41:32 +0100
From:   Alex Dewar <alex.dewar90@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Alex Dewar <alex.dewar90@...il.com>,
        Evgeniy Polyakov <zbr@...emap.net>,
        linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] w1: Remove pointless debug code

It doesn't seem obvious why zeroing sl before freeing it would help with
debugging, so just remove this code.

Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
---
 drivers/w1/w1.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 4f597b0fd1da..02a0e66144a4 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -801,9 +801,6 @@ int w1_unref_slave(struct w1_slave *sl)
 
 		w1_family_notify(BUS_NOTIFY_DEL_DEVICE, sl);
 		device_unregister(&sl->dev);
-		#ifdef DEBUG
-		memset(sl, 0, sizeof(*sl));
-		#endif
 		kfree(sl);
 	}
 	atomic_dec(&dev->refcnt);
-- 
2.28.0