lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 9 Sep 2020 14:15:59 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Linuxarm <linuxarm@...wei.com>, mauro.chehab@...wei.com,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, Yu Chen <chenyu56@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [RFC 03/10] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace

On Fri, Sep 4, 2020 at 4:23 AM Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Rename hikey970 to hi3670, in order to use a namespace
> similar to hi3660 driver.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  .../bindings/phy/phy-hi3670-usb3.txt          |  4 +-

Bindings should be a separate patch.

>  drivers/phy/hisilicon/phy-hi3670-usb3.c       | 98 +++++++++----------
>  2 files changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> index 4cb02612ff23..2fb27cb8beaf 100644
> --- a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> @@ -2,7 +2,7 @@ Hisilicon Kirin970 usb PHY
>  -----------------------
>
>  Required properties:
> -- compatible: should be "hisilicon,kirin970-usb-phy"
> +- compatible: should be "hisilicon,hi3670-usb-phy"

Unless this is unused, we can't just change it. It's an ABI.

>  - #phy-cells: must be 0
>  - hisilicon,pericrg-syscon: phandle of syscon used to control phy.
>  - hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> @@ -14,7 +14,7 @@ Refer to phy/phy-bindings.txt for the generic PHY binding properties
>
>  Example:
>         usb_phy: usbphy {
> -               compatible = "hisilicon,kirin970-usb-phy";
> +               compatible = "hisilicon,hi3670-usb-phy";
>                 #phy-cells = <0>;
>                 hisilicon,pericrg-syscon = <&crg_ctrl>;
>                 hisilicon,pctrl-syscon = <&pctrl>;

Powered by blists - more mailing lists