linux-kernel - Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 13:55:58 -0700
From:   Keith Busch <kbusch@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Jiri Kosina <trivial@...nel.org>,
        Kees Cook <kees.cook@...onical.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-mips@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, linux-input@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-rdma@...r.kernel.org,
        iommu@...ts.linux-foundation.org, dm-devel@...hat.com,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-mtd@...ts.infradead.org, intel-wired-lan@...ts.osuosl.org,
        oss-drivers@...ronome.com, linux-usb@...r.kernel.org,
        linux-wireless@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-nvme@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-scsi@...r.kernel.org,
        storagedev@...rochip.com, sparclinux@...r.kernel.org,
        linux-serial@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-parisc@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-afs@...ts.infradead.org, ceph-devel@...r.kernel.org,
        linux-nfs@...r.kernel.org, bpf@...r.kernel.org,
        dccp@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, linux-sctp@...r.kernel.org,
        alsa-devel <alsa-devel@...a-project.org>
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to
 break;

On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> index eea0f453cfb6..8aac5bc60f4c 100644
> --- a/crypto/tcrypt.c
> +++ b/crypto/tcrypt.c
> @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
>  		test_hash_speed("streebog512", sec,
>  				generic_hash_speed_template);
>  		if (mode > 300 && mode < 400) break;
> -		fallthrough;
> +		break;
>  	case 399:
>  		break;

Just imho, this change makes the preceding 'if' look even more
pointless. Maybe the fallthrough was a deliberate choice? Not that my
opinion matters here as I don't know this module, but it looked a bit
odd to me.