linux-kernel - Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 16:23:25 -0500
From:   Alex Elder <elder@...aro.org>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, evgreen@...omium.org, subashab@...eaurora.org,
        cpratapa@...eaurora.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend
 reference

On 9/9/20 4:14 PM, David Miller wrote:
> From: Alex Elder <elder@...aro.org>
> Date: Wed, 9 Sep 2020 08:43:44 -0500
> 
>> There is exactly one reference here; the "reference" is
>> essentially a Boolean flag.  So the value is always either
>> 0 or 1.
> 
> Aha, then why not use a bitmask and test_and_set_bit() et al.?

OK I'll go take a look at that option.  It's overkill for
bits used but it makes it more obvious it's a single bit,
so it's probably a better idea.

I'll try to turn this around again by tomorrow.  Thank you.

					-Alex