linux-kernel - Re: [PATCH v3] HID: add vivaldi HID driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200909223148.419843-1-seobrien@chromium.org>
Date:   Wed,  9 Sep 2020 15:31:48 -0700
From:   Sean O'Brien <seobrien@...omium.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Sean O'Brien <seobrien@...omium.org>
Subject: Re: [PATCH v3] HID: add vivaldi HID driver

> if ((parser->global.usage_page << 16) != HID_UP_GOOGLEVENDOR)
>	return;

I'm a bit worried about adding an early return, as it may cause issues
if someone doesn't notice when adding another case. Looking at this again
I can easily remove the second line break now that I've changed the group
name.