[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 9 Sep 2020 07:29:45 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Tim Harvey <tharvey@...eworks.com>,
Robert Jones <rjones@...eworks.com>,
Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-power@...rohmeurope.com
Subject: Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples
On Tue, 08 Sep 2020, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> Documentation/devicetree/bindings/mfd/act8945a.txt | 2 +-
> Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++-
> Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
Looks good, but I'd like the author to review.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists