linux-kernel - Re: [PATCH v2 0/2] leds: pwm: Make automatic labels work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 11:00:33 +0200
From:   Pavel Machek <pavel@....cz>
To:     Alexander Dahl <ada@...rsis.com>
Cc:     linux-leds@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Alexander Dahl <post@...pocky.de>, devicetree@...r.kernel.org,
        Dan Murphy <dmurphy@...com>, Rob Herring <robh+dt@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] leds: pwm: Make automatic labels work

Hi!

> > > for leds-gpio you can use the properties 'function' and 'color' in the
> > > devicetree node and omit 'label', the label is constructed
> > > automatically.  This is a common feature supposed to be working for all
> > > LED drivers.  However it did not yet work for the 'leds-pwm' driver.
> > > This series fixes the driver and takes the opportunity to update the
> > > dt-bindings accordingly.
> > > 
> > > v1: based on v5.9-rc2, backport on v5.4.59 tested and working
> > > 
> > > v2: based on v5.9-rc3, added the dt-bindings update patch
> > > 
> > > Greets
> > > Alex
> > > 
> > > Alexander Dahl (2):
> > >    leds: pwm: Allow automatic labels for DT based devices
> > >    dt-bindings: leds: Convert pwm to yaml
> > >   
> > >   .../devicetree/bindings/leds/leds-pwm.txt     | 50 -----------
> > >   .../devicetree/bindings/leds/leds-pwm.yaml    | 85 +++++++++++++++++++
> > >   drivers/leds/leds-pwm.c                       |  9 +-
> > >   3 files changed, 93 insertions(+), 51 deletions(-)
> > >   delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> > >   create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > 
> > For both patches:
> > 
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> 
> I'd like to make a v3 and change the license of the .yaml file to "(GPL-2.0-
> only OR BSD-2-Clause)" as suggested by checkpatch and [1].  Can I keep your 
> Acked-by for that?
> 
> Besides: those suggestions are obviously valid for new bindings.  What about 
> old bindings (.txt), which had no explicit SPDX tag or license note before?  
> What license would apply there?  Is the .yaml file technically new, when it 
> was mostly just converted from .txt?

If it is based on previous .txt binding, you have to respect previous
author's license. That probably means GPL-2.0 only.

Alternatively, you can contact original author(s) to get permission to
relicense under (GPL-2.0-only OR BSD-2-Clause).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)