linux-kernel - Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 11:54:40 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org
Cc:     kernel@...labora.com, dafna3@...il.com
Subject: Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for
 regulator-allowed-modes of da9211



On 04/09/2020 10:02, Enric Balletbo i Serra wrote:
> Hi Dafna,
> 
> Thank you to work on this.
> 
> On 3/9/20 16:28, Dafna Hirschfeld wrote:
>> According to the datasheet the allowed modes for the da9211
>> regulator are sync and auto mode. This should be changed in the
>> devicetree. This also fix an error message
>> 'BUCKA: invalid regulator-allowed-modes element 0'
>> since value 0 is invalid.
>>
>> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> 
> Double checked the regulator supported modes and I can confirm that this patch
> gets rid of the error message, so:
> 
> Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> 

Applied to v5.9-next/dts64

Thanks!

>> ---
>>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> index 1fe5dac24ba1..1a51879d5c6f 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>> @@ -5,6 +5,7 @@
>>   
>>   #include <dt-bindings/input/input.h>
>>   #include <dt-bindings/input/linux-event-codes.h>
>> +#include <dt-bindings/regulator/dlg,da9211-regulator.h>
>>   #include <dt-bindings/gpio/gpio.h>
>>   #include "mt8173.dtsi"
>>   
>> @@ -293,7 +294,8 @@
>>   				regulator-max-microamp  = <4400000>;
>>   				regulator-ramp-delay = <10000>;
>>   				regulator-always-on;
>> -				regulator-allowed-modes = <0 1>;
>> +				regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
>> +							   DA9211_BUCK_MODE_AUTO>;
>>   			};
>>   
>>   			da9211_vgpu_reg: BUCKB {
>>