linux-kernel - Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle commit messages with multiple quotes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 12:06:06 +0200 (CEST)
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Ayush <ayush@...root.org>
cc:     Joe Perches <joe@...ches.com>, apw@...onical.com,
        lukas.bulwahn@...il.com,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle
 commit messages with multiple quotes

On Tue, 8 Sep 2020, Ayush wrote:

> > I think all your examples are broken.
> > 
> > I think all should start with revert
> > i.e.: Reverts commit <SHA-1> ("description...")
> 
> Actually I am talking about those commits which referenced a revert commit.
> 
> For example:
> 
> If I want to mention a revert commit in my commit message, I will do something like.
> 
> This bug appeared first in commit 1234567890ab ("Revert "abc: foo bar"").
> (Just an example)
> 
> Here, according to syntax, it is right but checkpatch.pl gives an error as multiple
> quotes in commit messages are not handled in checkpatch.pl.
>

As the mentor in the linux kernel community bridge program, I usually 
inform the mentees when the review on the mentee mailing list has 
successfully concluded to a first acceptable state and I think it is well 
advised to reach out to the maintainers for further discussion.

You did not do that, but just send some patch to the maintainers.
That is fully up to you, but I will not support the patch acceptance in 
any way, and it suggests that you do not see the need to be mentored.

If you can land patches without mentoring support successfully, that is 
great, but then you do not need a mentorship.

Now, to the commit:

Ayush, your commit message is largely incomprehensible.

Your follow-up explanation that was needed should have been in the commit 
message in the first place.

Ayush, you did not sign-off with your full legal name.

So, I advice NOT TO TAKE this patch.

I did not even start testing and reviewing the code yet.

Lukas