linux-kernel - Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 12:23:45 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     Paul Cercueil <paul@...pouillou.net>,
        周琰杰 <zhouyanjie@...yeetech.com>,
        周正 <sernia.zhou@...mail.com>,
        漆鹏振 <aric.pzqi@...enic.com>, od@...c.me,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to
 HW register

Hi!

> >>>  -	reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT 
> >>> |	USBPCR_TXPREEMPHTUNE |
> >>>  +	return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT | 
> >>> USBPCR_TXPREEMPHTUNE |
> >>>   		USBPCR_COMMONONN | USBPCR_POR;
> >>>  -	writel(reg, priv->base + REG_USBPCR_OFFSET);
> >> 
> >> not a bug fix
> >
> > Well, if you don't like my bug fix, next time wait for my Reviewed-by.
> 
> why so angry? Take a break every once in a while. Besides, someone else
> already sent the oneliner before you ;-)

Your behaviour is pretty good explanation for angry people on the
mailing list.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)