[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 9 Sep 2020 13:00:06 +0200
From: Bartosz Golaszewski <bgolaszewski@...libre.com>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>,
Linus Walleij <linus.walleij@...aro.org>,
LKML <linux-kernel@...r.kernel.org>,
linux-gpio <linux-gpio@...r.kernel.org>,
Thorsten Scherer <t.scherer@...elmann.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs
On Wed, Sep 9, 2020 at 12:30 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> On Wed, Sep 09, 2020 at 11:43:24AM +0200, Bartosz Golaszewski wrote:
> > On Mon, Sep 7, 2020 at 5:32 PM Ahmad Fatoum <a.fatoum@...gutronix.de> wrote:
> > >
> > > The gpio-siox driver uses handle_nested_irq() to implement its
> > > interrupt support. This is only capable of handling threaded irq
> > > actions. For a hardirq action it triggers a NULL pointer oops.
> > > (It calls action->thread_fn which is NULL then.)
> > >
> > > Prevent registration of a hardirq action by setting
> > > gpio_irq_chip::threaded to true.
> > >
> > > Cc: u.kleine-koenig@...gutronix.de
> > > Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> > > ---
> >
> > Could you add a Fixes tag? This looks like stable material.
>
> Ah, we talked about this in the v1 thread---tglx and I agreed we want
> it. That's:
>
> Fixes: be8c8facc707 ("gpio: new driver to work with a 8x12 siox")
>
Thanks, now queued for fixes.
Bartosz
Powered by blists - more mailing lists