linux-kernel - Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle commit messages with multiple quotes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 13:32:30 +0200 (CEST)
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Ayush <ayush@...root.org>
cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: GIT_COMMIT_ID: handle
 commit messages with multiple quotes


dropped the maintainers.

On Wed, 9 Sep 2020, Ayush wrote:

> Sir,
> 
> > As the mentor in the linux kernel community bridge program, I usually
> > inform the mentees when the review on the mentee mailing list has
> > successfully concluded to a first acceptable state and I think it is well
> > advised to reach out to the maintainers for further discussion.
> > 
> > You did not do that, but just send some patch to the maintainers.
> > That is fully up to you, but I will not support the patch acceptance in
> > any way, and it suggests that you do not see the need to be mentored.
> > 
> > If you can land patches without mentoring support successfully, that is
> > great, but then you do not need a mentorship.
> 
> I am extremely sorry for my mistakes. It won't happen again.
>  
> > Now, to the commit:
> > 
> > Ayush, your commit message is largely incomprehensible.
> > 
> > Your follow-up explanation that was needed should have been in the commit
> > message in the first place.
> 
> It was my first patch, so I had very little idea of forming commit messages. 
> I will discuss it with mentors next time before sending the patch next time.
>

Let us start with the simpler patch and then see if you can write a commit 
message that convinces Joe to ack your patch.
 
> > Ayush, you did not sign-off with your full legal name.
> 
> My legal name according to all official identification documents of India is Ayush. 
> I have no surname registered legally.
> So should I include "Ayush <ayush@...root.org>"  or do I need to include my last name too (Which is Ayush only)?
>

Okay. If you say so, I cannot judge but you should try to use a name that 
others can with a fair chance uniquely identify that is you.

The name is used in git log summaries, pull requests, etc.; so, it should 
be a name that with high chance to refer to one person.

Maybe you find a good way that works as suitable name for 
unique identification?


Lukas