linux-kernel - Re: [PATCH 1/3] perf list: Remove dead code in argument check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 09:27:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH 1/3] perf list: Remove dead code in argument check

Em Wed, Sep 09, 2020 at 02:58:47PM +0900, Namhyung Kim escreveu:
> The sep is already checked being not NULL.  The code seems to be a
> leftover from some refactoring.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

There is a missing --- separator from the description to the patch, I
had to add it so that 'git am' works on it, please check.

- Arnaldo

I.e. it should be right here:

---

> 
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 0a7fe4cb5555..10ab5e40a34f 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -92,13 +92,6 @@ int cmd_list(int argc, const char **argv)
>  		else if ((sep = strchr(argv[i], ':')) != NULL) {
>  			int sep_idx;
>  
> -			if (sep == NULL) {
> -				print_events(argv[i], raw_dump, !desc_flag,
> -							long_desc_flag,
> -							details_flag,
> -							deprecated);
> -				continue;
> -			}
>  			sep_idx = sep - argv[i];
>  			s = strdup(argv[i]);
>  			if (s == NULL)
> -- 
> 2.28.0.526.ge36021eeef-goog
> 

-- 

- Arnaldo