linux-kernel - Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1599620917.2521.9.camel@mhfsdcap03>
Date:   Wed, 9 Sep 2020 11:08:37 +0800
From:   Jianjun Wang <jianjun.wang@...iatek.com>
To:     Rob Herring <robh@...nel.org>
CC:     <davem@...emloft.net>, Philipp Zabel <p.zabel@...gutronix.de>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        <linux-pci@...r.kernel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Sj Huang <sj.huang@...iatek.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller

On Tue, 2020-09-08 at 13:50 -0600, Rob Herring wrote:
> On Mon, 07 Sep 2020 20:08:50 +0800, Jianjun Wang wrote:
> > Add YAML schemas documentation for Gen3 PCIe controller on
> > MediaTek SoCs.
> > 
> > Acked-by: Ryder Lee <ryder.lee@...iatek.com>
> > Signed-off-by: Jianjun Wang <jianjun.wang@...iatek.com>
> > ---
> >  .../bindings/pci/mediatek-pcie-gen3.yaml      | 158 ++++++++++++++++++
> >  1 file changed, 158 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > 
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.example.dts:55.56-59.19: Warning (pci_device_reg): /example-0/bus/pcie@...30000/legacy-interrupt-controller: missing PCI reg property
> 
> 
> See https://patchwork.ozlabs.org/patch/1359119
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
> 
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> 
> Please check and re-submit.
> 

Yes, I have already found this warning message, but I'm confused with
how to add this reg property, since the interrupt-controller has inherit
the pci device type but does not have its own registers.

Could you please tell me how to fix this error, or which docs can I
refer to?

Thanks.