linux-kernel - Re: [PATCH v1] spi: spi-nxp-fspi: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 15:32:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Kuldip Dwivedi <kuldip.dwivedi@...esoftware.com>
Cc:     Ashish Kumar <ashish.kumar@....com>,
        Yogesh Gaur <yogeshgaur.83@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Varun Sethi <V.Sethi@....com>,
        Arokia Samy <arokia.samy@....com>
Subject: Re: [PATCH v1] spi: spi-nxp-fspi: Add ACPI support

On Wed, Sep 09, 2020 at 06:29:10PM +0530, Kuldip Dwivedi wrote:

> > | Does NXP know about this ID assignment from their namespace?  ACPI IDs
> > | should be namespaced by whoever's assigning the ID to avoid
> collisions.

> Yes, NXP is aware.

Can anyone from NXP confirm this?

> > Please don't ignore review comments, people are generally making them
> for a
> > reason and are likely to have the same concerns if issues remain

> This is new Patch for different IP (FSPI)  and scenario is different from
> DSPI driver.

If a generic issue like this exists with one patch you should expect
that exactly the same issue is going to come up with other very similar
patches and therefore ensure they are addressed so people don't feel
like you are ignoring them.

> > >  	/* Reset the module */
> > > +	fspi_writel(f, FSPI_MCR0_SWRST, (base + FSPI_MCR0));
> > > +

> > Why are you adding this reset?  How is it connected to adding ACPI
> support - it
> > looks like it should be a separate patch.

> I observed a kernel panic in setting up the driver, and this fixed the
> issue.

At the very least this would need to be called out in the changelog but
like I say it should really be a separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)