linux-kernel - Re: [PATCH V6] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Sep 2020 13:06:10 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Radoslaw Biernacki <rad@...ihalf.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     Lech Betlej <Lech.Betlej@...el.com>, alsa-devel@...a-project.org,
        Todd Broch <tbroch@...gle.com>,
        Harshapriya <harshapriya.n@...el.com>,
        John Hsu <KCHSU0@...oton.com>, linux-kernel@...r.kernel.org,
        michal.sienkiewicz@...el.com, Ben Zhang <benzh@...omium.org>,
        Mac Chiang <mac.chiang@...el.com>,
        Yong Zhi <yong.zhi@...el.com>, Marcin Wojtas <mw@...ihalf.com>,
        Vamshi Krishna <vamshi.krishna.gopal@...el.com>,
        Alex Levin <levinale@...gle.com>
Subject: Re: [PATCH V6] ASoC: Intel: boards: Use FS as nau8825 sysclk in
 nau88125_* machine



On 9/10/20 12:25 PM, Radoslaw Biernacki wrote:
> Since 256xFS clocks cannot be generated by SKL, the NAU8825 is
> configured to re-generate its system clock from the BCLK using the
> FLL. The link is configured to use a 48kHz frame rate, and 24 bits in
> 25-bit slot. The SSP configuration is extracted from NHLT settings and
> not dynamically changed. Listening tests and measurements do not show
> any distortion or issues
> 
> Signed-off-by: John Hsu <KCHSU0@...oton.com>
> Signed-off-by: Yong Zhi <yong.zhi@...el.com>
> Signed-off-by: Mac Chiang <mac.chiang@...el.com>
> Signed-off-by: Ben Zhang <benzh@...omium.org>
> Signed-off-by: Radoslaw Biernacki <rad@...ihalf.com>
> ---

LGTM, thanks!

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>