linux-kernel - Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200910184141.GD893045@ravnborg.org>
Date:   Thu, 10 Sep 2020 20:41:41 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        devicetree <devicetree@...r.kernel.org>,
        Laurentiu Palcu <laurentiu.palcu@....com>,
        Guido Günther <agx@...xcpu.org>,
        lukas@...mn.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller
 Subsystem

Hi Laurentiu

> > > I've tested this together with a hacked up eDP bridge driver stack on
> > > my boards. The testing hasn't been really in-depth, but things seem to
> > > work fine. I have now pushed the whole series into drm-misc-next.
> > 
> > Something doesn't compile too well
> > 
> > ERROR: modpost: "__aeabi_ldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > ERROR: modpost: "__aeabi_uldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> 
> Oops... :/ I guess we need an ARM64 dependency in Kconfig. No
> 32bit NXP SoC uses this particular display controller. So, that should
> fix the compilation issue on 32bit.

Build coverage for ARM64 is an OK short term fix.

Please fix the driver so we can build test it for all architectures.
The chance to miss something when refactoring if only build for ARM64
is too high. The fix can land when it is ready, and is not urgent.

	Sam