linux-kernel - Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200910.150548.696841576525551255.davem@davemloft.net>
Date:   Thu, 10 Sep 2020 15:05:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mayflowerera@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN
 links

From: Era Mayflower <mayflowerera@...il.com>
Date: Thu, 10 Sep 2020 09:56:09 +0000

> -		pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN;
> -		if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) {
> -			pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != %d\n",
> -				  nla_len(tb_sa[MACSEC_SA_ATTR_PN]), pn_len);
> +			pr_notice("macsec: nl: upd_rxsa: pn length on non-xpn links must be %d\n",
> +				  MACSEC_DEFAULT_PN_LEN);
> +			rtnl_unlock();
> +			return -EINVAL;
> +
> +		default:
> +			pr_notice("macsec: nl: upd_rxsa: pn length must be %d or %d\n",
> +				  MACSEC_DEFAULT_PN_LEN, MACSEC_XPN_PN_LEN);
>  			rtnl_unlock();

Please do not spam the kernel log like this.  Instead, report this
info via netlink extended ACKs.

Thank you.