linux-kernel - Re: [PATCH 00/11] mmc: Minor cleanups and compile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+ajm5aiAJfQdS2+2DO1ynBDHWha_7TsA4u-2qwd87y6g@mail.gmail.com>
Date:   Thu, 10 Sep 2020 16:55:24 -0600
From:   Rob Herring <robh@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        Al Cooper <alcooperx@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thierry Reding <thierry.reding@...il.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Michal Simek <michal.simek@...inx.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Ray Jui <rjui@...adcom.com>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@...ts.infradead.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Scott Branden <sbranden@...adcom.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Jun Nie <jun.nie@...aro.org>, Shawn Guo <shawnguo@...nel.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Subject: Re: [PATCH 00/11] mmc: Minor cleanups and compile test

On Thu, Sep 3, 2020 at 2:40 AM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Wed, 2 Sep 2020 at 21:37, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > Hi,
> >
> > Set of minor cleanups.  Patches requiring more attention:
> >  - 6/11: Testing and review would be appreciated,
> >  - 11/11: I build tested multiple architectures but not all and
> >    definitely no all possible configs. This one could sit on the lists
> >    for few days so 0-day would try it.
> >
> > Best regards,
> > Krzysztof
> >
> > Krzysztof Kozlowski (11):
> >   mmc: bcm2835: Simplify with dev_err_probe()
> >   mmc: davinci: Simplify with dev_err_probe()
> >   mmc: dw_mmc-zx: Simplify with dev_err_probe()
> >   mmc: jz4740: Simplify with dev_err_probe()
> >   mmc: meson: Simplify with dev_err_probe()
> >   mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe()
> >   mmc: sdhci-of-arasan: Simplify with dev_err_probe()
> >   mmc: sdhci-tegra: Simplify with dev_err_probe()
> >   mmc: dw_mmc: Simplify with dev_err_probe()
> >   mmc: sdhci-of-sparx5: Use proper printk format for dma_addr_t
> >   mmc: host: Enable compile testing of multiple drivers
> >
> >  drivers/mmc/host/Kconfig           | 42 ++++++++++++++++--------------
> >  drivers/mmc/host/bcm2835.c         |  4 +--
> >  drivers/mmc/host/davinci_mmc.c     |  5 ++--
> >  drivers/mmc/host/dw_mmc-zx.c       | 11 +++-----
> >  drivers/mmc/host/dw_mmc.c          |  9 +++----
> >  drivers/mmc/host/jz4740_mmc.c      |  5 ++--
> >  drivers/mmc/host/meson-gx-mmc.c    | 16 ++++--------
> >  drivers/mmc/host/sdhci-brcmstb.c   | 12 ++++-----
> >  drivers/mmc/host/sdhci-of-arasan.c |  7 +++--
> >  drivers/mmc/host/sdhci-of-sparx5.c |  4 +--
> >  drivers/mmc/host/sdhci-tegra.c     |  7 ++---
> >  11 files changed, 51 insertions(+), 71 deletions(-)
> >
> > --
> > 2.17.1
> >
>
> Series applied for next, except 11, thanks!

I see there's a bunch of these already, but I think we can do better
here than dev_err_probe. We have _optional variants for the case not
getting a resource is not an error. So the called functions like
devm_clk_get can print an error. We already have this for
platform_get_irq along with a coccinelle script to fix cases. I have a
WIP branch[1] doing this.

Rob

[1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dev_err-removal