linux-kernel - Re: [PATCH] clk: versatile: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159972466586.2295844.9075545722301677556@swboyd.mtv.corp.google.com>
Date:   Thu, 10 Sep 2020 00:57:45 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Sumera Priyadarsini <sylphrenadin@...il.com>,
        linus.walleij@...aro.org
Cc:     mturquette@...libre.com, Julia.Lawall@...6.fr,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: versatile: Add of_node_put() before return statement

Quoting Sumera Priyadarsini (2020-08-29 10:57:04)
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
> 
> Fix a potential memory leak in clk-impd1.c by inserting
> of_node_put() before a return statement.
> 
> Issue found with Coccinelle.
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>
> ---

Applied to clk-fixes