linux-kernel - Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159972862952.2295844.10882678924928944990@swboyd.mtv.corp.google.com>
Date:   Thu, 10 Sep 2020 02:03:49 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>, agross@...nel.org,
        bjorn.andersson@...aro.org, mturquette@...libre.com,
        tdas@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, jingxiangfeng@...wei.com
Subject: Re: [PATCH] clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe()

Quoting Jing Xiangfeng (2020-08-27 07:16:29)
> lpass_core_sc7180_probe() misses to call pm_clk_destroy() and
> pm_runtime_disable() in error paths. Correct goto target to fix it.
> This issue is found by code inspection.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---

HMm.. presumably

Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180")

should be added?