linux-kernel - Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200910090625.GL1891694@smile.fi.intel.com>
Date:   Thu, 10 Sep 2020 12:06:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Matt Porter <mporter@...nel.crashing.org>,
        linux-kernel@...r.kernel.org
Cc:     Alexandre Bounine <alexandre.bounine@....com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES

On Tue, Aug 13, 2019 at 05:39:06PM +0300, Andy Shevchenko wrote:
> DMADEVICES option depends on HAS_DMA, and this dependency is ignored
> when DMADEVICES is being selected.
> 
> Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.

Yeah, I'm wondering why we got this into kernel much later (as
d2b861002450 ("rapidio: Replace 'select' DMAENGINES 'with depends on'") in
linux next and no one commented on this...

> Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")
> Cc: Alexandre Bounine <alexandre.bounine@....com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/rapidio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
> index 677d1aff61b7..788e7830771b 100644
> --- a/drivers/rapidio/Kconfig
> +++ b/drivers/rapidio/Kconfig
> @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
>  config RAPIDIO_DMA_ENGINE
>  	bool "DMA Engine support for RapidIO"
>  	depends on RAPIDIO
> -	select DMADEVICES
> +	depends on DMADEVICES
>  	select DMA_ENGINE
>  	help
>  	  Say Y here if you want to use DMA Engine frameork for RapidIO data
> -- 
> 2.20.1
> 

-- 
With Best Regards,
Andy Shevchenko