linux-kernel - Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910093353.GN1891694@smile.fi.intel.com>
Date:   Thu, 10 Sep 2020 12:33:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     "Tanwar, Rahul" <rahul.tanwar@...ux.intel.com>
Cc:     jdelvare@...e.com, linux@...ck-us.net, p.zabel@...gutronix.de,
        linux-hwmon@...r.kernel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        songjun.Wu@...el.com, cheol.yong.kim@...el.com,
        qi-ming.wu@...el.com, rtanwar@...linear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

On Thu, Sep 10, 2020 at 03:26:04PM +0800, Tanwar, Rahul wrote:
> On 9/9/2020 6:33 pm, Andy Shevchenko wrote:
> > On Wed, Sep 09, 2020 at 02:52:05PM +0800, Rahul Tanwar wrote:

...

> >> +#include <linux/of.h>
> > I don't see anything special about OF here.
> > Perhaps
> > 	mod_devicetable.h
> > 	property.h
> > ?
> 
> of.h is needed because of of_property_read_u8_array(). I will add
> mod_devicetable.h.
> property.h seems not required at all.

if you use device property API then it will be more generic.

...

> >> +static struct regmap_config pvt_regmap_config = {
> >> +	.reg_bits = 32,
> >> +	.reg_stride = 4,
> >> +	.val_bits = 32,
> > How do you use regmap's lock?
> 
> We mutex lock whenever read temperature or voltage values from the registers.
> All non-probe/non-init paths. We do not override regmap's internal lock.

Exactly and my point is why do we have too many locks?

> >> +};

-- 
With Best Regards,
Andy Shevchenko