linux-kernel - Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0392219-a9aa-169b-a1eb-44644392f06f@linux.intel.com>
Date:   Thu, 10 Sep 2020 18:42:15 +0800
From:   "Tanwar, Rahul" <rahul.tanwar@...ux.intel.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>, jdelvare@...e.com,
        linux@...ck-us.net, linux-hwmon@...r.kernel.org, robh+dt@...nel.org
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        andriy.shevchenko@...el.com, songjun.Wu@...el.com,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com,
        rtanwar@...linear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller



On 10/9/2020 6:35 pm, Philipp Zabel wrote:
> On Wed, 2020-09-09 at 14:52 +0800, Rahul Tanwar wrote:
>> PVT controller (MR75203) is used to configure & control
>> Moortec embedded analog IP which contains temprature
>> sensor(TS), voltage monitor(VM) & process detector(PD)
>> modules. Add driver to support MR75203 PVT controller.
>>
>> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
>> ---
> [...]
>> +static int mr75203_probe(struct platform_device *pdev)
>> +{
>> +	const struct hwmon_channel_info **pvt_info;
>> +	u32 ts_num, vm_num, pd_num, val, index, i;
>> +	struct device *dev = &pdev->dev;
>> +	u32 *temp_config, *in_config;
>> +	struct device *hwmon_dev;
>> +	struct pvt_device *pvt;
>> +	int ret;
>> +
>> +	pvt = devm_kzalloc(dev, sizeof(*pvt), GFP_KERNEL);
>> +	if (!pvt)
>> +		return -ENOMEM;
>> +
>> +	ret = pvt_get_regmap(pdev, "common");
>> +	if (ret)
>> +		return ret;
>> +
>> +	pvt->rst = devm_reset_control_get(dev, NULL);
> Please use devm_reset_control_get_exclusive().

Well noted. Missed that, thanks.

Regards,
Rahul