linux-kernel - Re: linux-next: Tree for Sep 9 (drivers/usb/typec/mux/intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Sep 2020 13:49:11 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>
Subject: Re: linux-next: Tree for Sep 9
 (drivers/usb/typec/mux/intel_pmc_mux.c)

On Wed, Sep 09, 2020 at 09:04:53AM -0700, Randy Dunlap wrote:
> On 9/9/20 3:26 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20200908:
> > 
> 
> on x86_64:
> 
>   CC [M]  drivers/usb/typec/mux/intel_pmc_mux.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘update_port_status’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:151:21: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
>   port->iom_status = readl(port->pmc->iom_base + IOM_PORT_STATUS_OFFSET +
>                      ^~~~~
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘is_memory’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:524:10: error: implicit declaration of function ‘acpi_dev_resource_memory’; did you mean ‘acpi_os_read_memory’? [-Werror=implicit-function-declaration]
>   return !acpi_dev_resource_memory(res, &r);
>           ^~~~~~~~~~~~~~~~~~~~~~~~
>           acpi_os_read_memory
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘pmc_usb_probe_iom’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:539:8: error: implicit declaration of function ‘acpi_dev_get_resources’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
>   ret = acpi_dev_get_resources(adev, &resource_list, is_memory, NULL);
>         ^~~~~~~~~~~~~~~~~~~~~~
>         acpi_get_event_resources
>   CC      drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c:547:2: error: implicit declaration of function ‘acpi_dev_free_resource_list’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
>   acpi_dev_free_resource_list(&resource_list);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   acpi_get_event_resources
> ../drivers/usb/typec/mux/intel_pmc_mux.c:550:19: error: dereferencing pointer to incomplete type ‘struct acpi_device’
>    put_device(&adev->dev);

It looks like we are missing ACPI dependency in Kconfig and a include.
I'll prepare the fixes.

Thanks Randy,

-- 
heikki