linux-kernel - Re: [PATCH] i2c: stm32: do not display error when DMA is not requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910122739.GA5093@gnbcxd0016.gnb.st.com>
Date:   Thu, 10 Sep 2020 14:27:39 +0200
From:   Alain Volmat <alain.volmat@...com>
To:     Wolfram Sang <wsa@...nel.org>
CC:     <pierre-yves.mordret@...com>, <alexandre.torgue@...com>,
        <linux-i2c@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <fabrice.gasnier@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Holger Assmann <h.assmann@...gutronix.de>
Subject: Re: [PATCH] i2c: stm32: do not display error when DMA is not
 requested

On Thu, Sep 10, 2020 at 12:06:07PM +0200, Wolfram Sang wrote:
> On Thu, Sep 10, 2020 at 11:32:29AM +0200, Alain Volmat wrote:
> > DMA usage is optional for the I2C driver. check for the -ENODEV
> > error in order to avoid displaying an error when no DMA
> > has been requested.
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@...com>
> > ---
> > This patch should be applied on top of the patch [i2c: stm32: Simplify with dev_err_probe()]
> 
> We can do it in this order, it just makes backporting to stable kernels
> (if that is desired) a bit harder than a self-contained patch. I am fine
> with both approaches, but just wanted to point it out.

Indeed, that's a good point. I'll rework it then, to avoid the dependency
on dev_err_probe change. If that is ok, I propose to push a two patches serie
with both this fix (updated) followed by a rebased version of the
dev_err_probe patch from Krzysztof for dev_err_probe change.