linux-kernel - Re: [PATCH] qedr: fix resource leak in qedr_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEYrHj=pfGB7OuHt90t2aaawr31W9XZCHeHJurt3o0rK44jZ+A@mail.gmail.com>
Date:   Fri, 11 Sep 2020 01:31:38 +0900
From:   Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     linux-rdma@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Ariel Elior <aelior@...vell.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Michal Kalderon <mkalderon@...vell.com>,
        Takafumi Kubota <takafumi@...ab.ics.keio.ac.jp>,
        Yuval Bason <yuval.bason@...ium.com>
Subject: Re: [PATCH] qedr: fix resource leak in qedr_create_qp

Hi,

Thank you for your comment.
I will re-label the goto statements and post the patch as version 2.

Thanks,
Keita

2020年9月10日(木) 22:24 Markus Elfring <Markus.Elfring@....de>:
>
> > Fix this by adding a new goto label that calls qedr_free_qp_resources.
>
> …
> > +++ b/drivers/infiniband/hw/qedr/verbs.c
> …
> > @@ -2165,11 +2187,13 @@ struct ib_qp *qedr_create_qp(struct ib_pd *ibpd,
> …
> >       return &qp->ibqp;
> >
> > +err2:
> > +     qedr_free_qp_resources(dev, qp, udata);
> >  err:
> >       kfree(qp);
>
> I propose to choose further alternatives for numbered labels.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=7fe10096c1508c7f033d34d0741809f8eecc1ed4#n485
>
> Regards,
> Markus