linux-kernel - Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1599706080.10649.30.camel@mtkswgap22>
Date:   Thu, 10 Sep 2020 10:48:00 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     Can Guo <cang@...eaurora.org>, <asutoshd@...eaurora.org>,
        <nguyenb@...eaurora.org>, <hongwus@...eaurora.org>,
        <ziqichen@...eaurora.org>, <rnayak@...eaurora.org>,
        <linux-scsi@...r.kernel.org>, <kernel-team@...roid.com>,
        <saravanak@...gle.com>, <salyzyn@...gle.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        Bean Huo <beanhuo@...ron.com>,
        "Bart Van Assche" <bvanassche@....org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from
 doorbell

Hi Martin, Can,

On Wed, 2020-09-09 at 22:32 -0400, Martin K. Petersen wrote:
> Can and Stanley,
> 
> > I can't reconcile this hunk:
> 
> Please provide a resolution for these conflicting commits in fixes and
> queue:
> 
> 307348f6ab14 scsi: ufs: Abort tasks before clearing them from doorbell
> 
> b10178ee7fa8 scsi: ufs: Clean up completed request without interrupt
> notification
> 

Can's patch has considered my fix in the new flow.

To be more clear, for the fixing case in my patch,
ufshcd_try_to_abort_task() will return 0 (err = 0) and finally the
target tag can be completed and cleared by __ufshcd_transfer_req_compl()
in Can's new flow.

Thus I think the resolution can just using the code in Can's patch.

Can, please correct me if I was wrong.

Thanks,
Stanley Chu


> Thanks!
>