linux-kernel - Re: [PATCH] drm/bridge: dw-mipi-dsi: Use kmemdup cf. kmalloc+memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c14d055d-1f6e-8c46-3a6e-7794ec69e6fe@baylibre.com>
Date:   Fri, 11 Sep 2020 14:57:41 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Philippe Cornu <philippe.cornu@...com>,
        Yannick Fertré <yannick.fertre@...com>,
        Antonio Borneo <antonio.borneo@...com>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>,
        Angelo Ribeiro <Angelo.Ribeiro@...opsys.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Use kmemdup cf. kmalloc+memcpy

On 09/09/2020 21:02, Alex Dewar wrote:
> kmemdup can be used instead of kmalloc+memcpy. Replace an occurrence of
> this pattern.
> 
> Issue identified with Coccinelle.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 52f5c5a2ed64..7e9a62ad56e8 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1049,12 +1049,10 @@ static void debugfs_create_files(void *data)
>  	};
>  	int i;
>  
> -	dsi->debugfs_vpg = kmalloc(sizeof(debugfs), GFP_KERNEL);
> +	dsi->debugfs_vpg = kmemdup(debugfs, sizeof(debugfs), GFP_KERNEL);
>  	if (!dsi->debugfs_vpg)
>  		return;
>  
> -	memcpy(dsi->debugfs_vpg, debugfs, sizeof(debugfs));
> -
>  	for (i = 0; i < ARRAY_SIZE(debugfs); i++)
>  		debugfs_create_file(dsi->debugfs_vpg[i].name, 0644,
>  				    dsi->debugfs, &dsi->debugfs_vpg[i],
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>

Thanks,
Neil