linux-kernel - Re: [PATCH 1/3] mm: replace memmap_context by memplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a987f876-9d59-f998-b8ab-5f6b79b35ffb@redhat.com>
Date:   Fri, 11 Sep 2020 19:34:25 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Laurent Dufour <ldufour@...ux.ibm.com>, akpm@...ux-foundation.org,
        Oscar Salvador <osalvador@...e.de>, mhocko@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-mm@...ck.org, "Rafael J . Wysocki" <rafael@...nel.org>,
        nathanl@...ux.ibm.com, cheloha@...ux.ibm.com,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context

On 11.09.20 18:23, Laurent Dufour wrote:
> Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>>>   		struct page *start;
>>>   		struct memmap_init_callback_data args;
>>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>>> index 375515803cd8..cd2bd21d3a4d 100644
>>> --- a/include/linux/memory_hotplug.h
>>> +++ b/include/linux/memory_hotplug.h
>>> @@ -15,6 +15,15 @@ struct memory_block;
>>>   struct resource;
>>>   struct vmem_altmap;
>>>   
>>> +/*
>>> + * Memory plugin context, use to differentiate memory added at boot time and
>>
>> "Memory plugin context" sounds weird.
> 
> Any suggestion ?
> 

I'm not a native speaker, but "plugin" sounds weird in this context.
Maybe simply drop it and start right away with "Differentiate memory
added ..."

-- 
Thanks,

David / dhildenb