[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACPK8XfmDySpkCw8nkmns-euGQE6JTqZLVO6JhvFJiRqNosRuQ@mail.gmail.com>
Date: Fri, 11 Sep 2020 00:58:05 +0000
From: Joel Stanley <joel@....id.au>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
BenoƮt Cousson <bcousson@...libre.com>,
Tony Lindgren <tony@...mide.com>,
Russell King <linux@...linux.org.uk>,
Jason Cooper <jason@...edaemon.net>,
Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Andrew Jeffery <andrew@...id.au>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Tero Kristo <t-kristo@...com>, Nishanth Menon <nm@...com>,
Michal Simek <michal.simek@...inx.com>,
Guenter Roeck <linux@...ck-us.net>,
devicetree <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-omap@...r.kernel.org,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
linux-mediatek@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 12/15] ARM: dts: aspeed: align GPIO hog names with dtschema
On Thu, 10 Sep 2020 at 17:59, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> dtschema for pca95xx expects GPIO hogs to end with 'hog' prefix.
This is a bit ugly. Do we have to go down this path?
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +-
> arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 1fa233d2da26..0aa437486a0d 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -560,7 +560,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus0 {
> + smbus0-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> index cb85168f6761..577c211c469e 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> @@ -827,7 +827,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus0 {
> + smbus0-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -852,7 +852,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus1 {
> + smbus1-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -900,7 +900,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus2 {
> + smbus2-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -925,7 +925,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus3 {
> + smbus3-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -992,7 +992,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus4 {
> + smbus4-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -1017,7 +1017,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus5 {
> + smbus5-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -1065,7 +1065,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus6 {
> + smbus6-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> @@ -1090,7 +1090,7 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - smbus7 {
> + smbus7-hog {
> gpio-hog;
> gpios = <4 GPIO_ACTIVE_HIGH>;
> output-high;
> --
> 2.17.1
>
Powered by blists - more mailing lists