linux-kernel - Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJht_EPZdsgO9SEtgxRMTcGj5z0xJVp-LOTiU0wH41rLLfG+EA@mail.gmail.com>
Date:   Fri, 11 Sep 2020 16:49:45 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF_OUTWAIT"

On Fri, Sep 11, 2020 at 2:44 PM David Miller <davem@...emloft.net> wrote:
>
> From: Xie He <xie.he.0141@...il.com>
> Date: Thu, 10 Sep 2020 23:35:03 -0700
>
> > The "SLF_OUTWAIT" flag defined in x25_asy.h is not actually used.
> > It is only cleared at one place in x25_asy.c but is never read or set.
> > So we can remove it.
> >
> > Signed-off-by: Xie He <xie.he.0141@...il.com>
>
> Applied, it looks like this code wss based upon the slip.c code.

Oh! You are right! I can finally understand now why there are so many
things named "sl" in this file.