linux-kernel - Re: [PATCH v5] perf: arm_dsu: Support DSU ACPI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b04416d-497b-4687-2c79-08d029cf758d@arm.com>
Date:   Fri, 11 Sep 2020 07:33:23 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     tuanphan@...eremail.onmicrosoft.com
Cc:     will@...nel.org, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] perf: arm_dsu: Support DSU ACPI devices

On 09/10/2020 08:07 PM, Tuan Phan wrote:
> Hi Will,
> 
>> On Sep 10, 2020, at 6:40 AM, kernel test robot <lkp@...el.com> wrote:
>>
>> Hi Tuan,
>>
>> Thank you for the patch! Perhaps something to improve:
>>
>> [auto build test WARNING on linus/master]
>> [also build test WARNING on v5.9-rc4 next-20200910]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/0day-ci/linux/commits/Tuan-Phan/perf-arm_dsu-Support-DSU-ACPI-devices/20200910-105630
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ab29a807a7ddaa7c84d2f4cb8d29e74e33759072
>> config: arm64-randconfig-r012-20200909 (attached as .config)
>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0a5dc7effb191eff740e0e7ae7bd8e1f6bdb3ad9)
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # install arm64 cross compiling tool for clang build
>>         # apt-get install binutils-aarch64-linux-gnu
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/perf/arm_dsu_pmu.c:799:36: warning: unused variable 'dsu_pmu_acpi_match' [-Wunused-const-variable]
>>    static const struct acpi_device_id dsu_pmu_acpi_match[] = {
>>                                       ^
>>    1 warning generated.
>>
> 
> Do you need me to fix this warning when CONFIG_ACPI not defined?

Yes, please. The kernel should compile fine in any config. Any compiler
warning is not good (unless the compiler is wrong).

Cheers
Suzuki