linux-kernel - Re: [PATCH 21/24] aio.7: Use perror() directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b27eeb1-744a-af3b-e155-58802d25ba03@gmail.com>
Date:   Fri, 11 Sep 2020 08:42:54 +0200
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Alejandro Colomar <colomar.6.4.3@...il.com>
Cc:     mtk.manpages@...il.com, linux-man@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/24] aio.7: Use perror() directly

On 9/10/20 11:13 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@...il.com>

Thanks, Alex. Patch applied.

Cheers,

Michael

> ---
>  man7/aio.7 | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/man7/aio.7 b/man7/aio.7
> index ff099885e..9b2c44c48 100644
> --- a/man7/aio.7
> +++ b/man7/aio.7
> @@ -257,8 +257,6 @@ aio_return():
>  
>  #define errExit(msg) do { perror(msg); exit(EXIT_FAILURE); } while (0)
>  
> -#define errMsg(msg)  do { perror(msg); } while (0)
> -
>  struct ioRequest {      /* Application\-defined structure for tracking
>                             I/O requests */
>      int           reqNum;
> @@ -390,7 +388,7 @@ main(int argc, char *argv[])
>                      else if (s == AIO_ALLDONE)
>                          printf("I/O all done\en");
>                      else
> -                        errMsg("aio_cancel");
> +                        perror("aio_cancel");
>                  }
>              }
>  
> @@ -418,7 +416,7 @@ main(int argc, char *argv[])
>                      printf("Canceled\en");
>                      break;
>                  default:
> -                    errMsg("aio_error");
> +                    perror("aio_error");
>                      break;
>                  }
>  
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/