lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Sep 2020 10:15:19 +0200 From: Daniel Vetter <daniel@...ll.ch> To: Hyun Kwon <hyun.kwon@...inx.com> Cc: Jason Yan <yanaijie@...wei.com>, "laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>, "airlied@...ux.ie" <airlied@...ux.ie>, "daniel@...ll.ch" <daniel@...ll.ch>, Michal Simek <michals@...inx.com>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hulk Robot <hulkci@...wei.com> Subject: Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666' On Thu, Sep 10, 2020 at 11:14:18AM -0700, Hyun Kwon wrote: > Hi Jason, > > On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote: > > This addresses the following gcc warning with "make W=1": > > > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning: > > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=] > > 245 | static const u32 scaling_factors_666[] = { > > | ^~~~~~~~~~~~~~~~~~~ > > > > Reported-by: Hulk Robot <hulkci@...wei.com> > > Signed-off-by: Jason Yan <yanaijie@...wei.com> > > Reviewed-by: Hyun Kwon <hyun.kwon@...inx.com> I think you're the maintainer, so please also push patches to drm-misc-next. Otherwise they'll just get lost, or at least it's very confusing when a maintainer reviews a patch but there's no indication what will happen with the patch. -Daniel > > Thanks! > > -hyun > > > --- > > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > index a455cfc1bee5..98bd48f13fd1 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > > @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = { > > ZYNQMP_DISP_AV_BUF_5BIT_SF, > > }; > > > > -static const u32 scaling_factors_666[] = { > > - ZYNQMP_DISP_AV_BUF_6BIT_SF, > > - ZYNQMP_DISP_AV_BUF_6BIT_SF, > > - ZYNQMP_DISP_AV_BUF_6BIT_SF, > > -}; > > - > > static const u32 scaling_factors_888[] = { > > ZYNQMP_DISP_AV_BUF_8BIT_SF, > > ZYNQMP_DISP_AV_BUF_8BIT_SF, > > -- > > 2.25.4 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists