linux-kernel - RE: [PATCH] fs: use correct parameter in notes of generic_file_llseek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3808373d663146c882c22397a1d6587f@h3c.com>
Date:   Fri, 11 Sep 2020 02:06:18 +0000
From:   Tianxianting <tian.xianting@....com>
To:     "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] fs: use correct parameter in notes of
 generic_file_llseek_size()

Hi viro,
Could I get your feedback?
This patch fixed the build warning, I think it can be applied, thanks :) 

-----Original Message-----
From: tianxianting (RD) 
Sent: Saturday, September 05, 2020 3:15 PM
To: viro@...iv.linux.org.uk
Cc: linux-fsdevel@...r.kernel.org; linux-kernel@...r.kernel.org; tianxianting (RD) <tian.xianting@....com>
Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()

Fix warning when compiling with W=1:
fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size'
fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size'

Signed-off-by: Xianting Tian <tian.xianting@....com>
---
 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index 5db58b8c7..058563ee2 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos);
  * @file:	file structure to seek on
  * @offset:	file offset to seek to
  * @whence:	type of seek
- * @size:	max size of this file in file system
+ * @maxsize:	max size of this file in file system
  * @eof:	offset used for SEEK_END position
  *
  * This is a variant of generic_file_llseek that allows passing in a custom
-- 
2.17.1