linux-kernel - Re: [PATCH 23/24] select_tut.2: Use MAX(a, b) from <sys/param.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3170056b-f99d-dad4-9418-777d3af80f03@gmail.com>
Date:   Fri, 11 Sep 2020 12:03:39 +0200
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Alejandro Colomar <colomar.6.4.3@...il.com>
Cc:     mtk.manpages@...il.com, linux-man@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 23/24] select_tut.2: Use MAX(a, b) from <sys/param.h>

On 9/11/20 10:46 AM, Alejandro Colomar wrote:
> Hi Michael,
> 
> On 2020-09-11 09:54, Michael Kerrisk (man-pages) wrote:
>> Hi Alex,
>>
>> On 9/10/20 11:13 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@...il.com>
>>
>> I'm reluctant to apply this, because MAX() is not a standard
>> macro. I suppose it may not be present on some other UNIX
>> systems. You thoughts?
> 
> I know the BSDs have it; maybe not all of them (I don't know them all), 
> but it is present at least in OpenBSD, libbsd, FreeBSD so I guess it's 
> common enough.
> For other UNIX systems, I have no idea.
> Maybe there's some unicorn UNIX that doesn't have it... impossible to tell.

Yup. So, I think I will skip this patch.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/