linux-kernel - Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Sep 2020 14:16:02 +0300
From:   Ard Biesheuvel <ard.biesheuvel@....com>
To:     Mark Brown <broonie@...nel.org>,
        kuldip dwivedi <kuldip.dwivedi@...esoftware.com>
Cc:     Ashish Kumar <ashish.kumar@....com>,
        Yogesh Gaur <yogeshgaur.83@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Varun Sethi <V.Sethi@....com>,
        Arokia Samy <arokia.samy@....com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@....com>,
        Paul Yang <Paul.Yang@....com>
Subject: Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

On 9/11/20 1:00 PM, Mark Brown wrote:
> On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote:
> 
>>   	/* find the resources - configuration register address space */
>>   	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base");
>> +#ifdef CONFIG_ACPI
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +#endif
> 
> This is buggy, it is equivalent to just removing the name based lookup
> since we'll do the name based lookup then unconditionally overwrite the
> results with an index based lookup.
> 

Also, note that CONFIG_ACPI kernels may still boot in DT mode.