linux-kernel - Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Sep 2020 13:17:41 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Kuldip Dwivedi <kuldip.dwivedi@...esoftware.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@....com>,
        Ashish Kumar <ashish.kumar@....com>,
        Yogesh Gaur <yogeshgaur.83@...il.com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Varun Sethi <V.Sethi@....com>,
        Arokia Samy <arokia.samy@....com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@....com>,
        Paul Yang <Paul.Yang@....com>
Subject: Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

On Fri, Sep 11, 2020 at 05:32:24PM +0530, Kuldip Dwivedi wrote:

> Here I can think two possible approaches
> 1. Changes in DT to use indexed based lookup

This is not going to be OK, it will break existing users relying on the
naming and makes the DTs less usable.

> 2. We Can check for ACPI fw node to distinguish between DT and ACPI like
> below..
> if (is_acpi_node(f->dev->fwnode))
> 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> else
> 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "fspi_base");

Yes, this should be good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)