linux-kernel - Re: [PATCH v2 2/2] usb: ohci: Make distrust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200911151734.GB884518@rowland.harvard.edu>
Date:   Fri, 11 Sep 2020 11:17:34 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Hamish Martin <hamish.martin@...iedtelesis.co.nz>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] usb: ohci: Make distrust_firmware param default
 to false

On Fri, Sep 11, 2020 at 09:25:12AM +1200, Hamish Martin wrote:
> The 'distrust_firmware' module parameter dates from 2004 and the USB
> subsystem is a lot more mature and reliable now than it was then.
> Alter the default to false now.
> 
> Suggested-by: Alan Stern <stern@...land.harvard.edu>
> Signed-off-by: Hamish Martin <hamish.martin@...iedtelesis.co.nz>
> ---
>  drivers/usb/host/ohci-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index 2845ea328a06..73e13e7c2b46 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -102,7 +102,7 @@ static void io_watchdog_func(struct timer_list *t);
>  
>  
>  /* Some boards misreport power switching/overcurrent */
> -static bool distrust_firmware = true;
> +static bool distrust_firmware;
>  module_param (distrust_firmware, bool, 0);
>  MODULE_PARM_DESC (distrust_firmware,
>  	"true to distrust firmware power/overcurrent setup");
> -- 
> 2.28.0

Acked-by: Alan Stern <stern@...land.harvard.edu>