linux-kernel - Re: [PATCH v3] cypto: mediatek - fix leaks in mtk_desc_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200911032607.GA5096@gondor.apana.org.au>
Date:   Fri, 11 Sep 2020 13:26:07 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Xiaoliang Pang <dawning.pang@...il.com>
Cc:     davem@...emloft.net, matthias.bgg@...il.com, swboyd@...omium.org,
        yuehaibing@...wei.com, tianjia.zhang@...ux.alibaba.com,
        ryder.lee@...iatek.com, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] cypto: mediatek - fix leaks in mtk_desc_ring_alloc

On Fri, Sep 11, 2020 at 09:36:19AM +0800, Xiaoliang Pang wrote:
>
> diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c
> index 7e3ad085b5bd..ebb3bdef0dbe 100644
> --- a/drivers/crypto/mediatek/mtk-platform.c
> +++ b/drivers/crypto/mediatek/mtk-platform.c
> @@ -469,13 +469,13 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
>  	return 0;
>  
>  err_cleanup:
> -	for (; i--; ) {
> +	do {
>  		dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
>  				  ring[i]->res_base, ring[i]->res_dma);
>  		dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
>  				  ring[i]->cmd_base, ring[i]->cmd_dma);
>  		kfree(ring[i]);
> -	}
> +	}while(i--);

Please add spaces before and after while.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt