linux-kernel - Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200911083825.55eb2f49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 11 Sep 2020 08:38:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luo Jiaxing <luojiaxing@...wei.com>, <mcoquelin.stm32@...il.com>
Cc:     <peppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <joabreu@...opsys.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void
 for it didn't have any error code to return

On Fri, 11 Sep 2020 11:55:58 +0800 Luo Jiaxing wrote:
> We found the following warning when using W=1 to build kernel:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> int ret, coe = priv->hw->rx_csum;
> 
> When digging stmmac_get_rx_header_len(), dwmac4_get_rx_header_len() and
> dwxgmac2_get_rx_header_len() return 0 only, without any error code to
> report. Therefore, it's better to define get_rx_header_len() as void.
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>