linux-kernel - Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d9b6e46-8337-9614-8fd7-b6ada8fcbe13@suse.cz>
Date:   Fri, 11 Sep 2020 17:13:43 +0200
From:   Martin Doucha <mdoucha@...e.cz>
To:     Cyril Hrubis <chrubis@...e.cz>, ltp@...ts.linux.it
Cc:     Alexandre Chartre <alexandre.chartre@...cle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, lkp@...ts.01.org,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

Hi,
the code looks good, though it might make sense to simply integrate the
check into ptrace08. Just 6 extra lines in the existing test should
achieve the same coverage.

It also seems the bug existed long before the CVE 2018-1000199 fix
because the test fails on vulnerable kernels as well.

Anyway, if you prefer to keep the patch as is:

Reviewed-by: Martin Doucha <mdoucha@...e.cz>

On 04. 09. 20 20:00, Cyril Hrubis wrote:
> New regression test for a kernel commit:
> 
> commit bd14406b78e6daa1ea3c1673bda1ffc9efdeead0
> Author: Jiri Olsa <jolsa@...nel.org>
> Date:   Mon Aug 27 11:12:25 2018 +0200
> 
>     perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set
> 
> Signed-off-by: Cyril Hrubis <chrubis@...e.cz>
> CC: Andy Lutomirski <luto@...nel.org>
> CC: Peter Zijlstra <peterz@...radead.org>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Alexandre Chartre <alexandre.chartre@...cle.com>
> ---


-- 
Martin Doucha   mdoucha@...e.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic