linux-kernel - Re: [PATCH 2/6] x86: Simplify compat syscall userspace allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200912070802.GA19621@lst.de>
Date:   Sat, 12 Sep 2020 09:08:02 +0200
From:   Christoph Hellwig <hch@....de>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     luto@...nel.org, tglx@...utronix.de, hpa@...or.com, bp@...en8.de,
        rric@...nel.org, peterz@...radead.org, mingo@...hat.com,
        x86@...nel.org, linux-kernel@...r.kernel.org, kernel@...labora.com,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 2/6] x86: Simplify compat syscall userspace allocation

On Sat, Sep 12, 2020 at 03:05:49AM -0400, Gabriel Krisman Bertazi wrote:
> When allocating user memory space for a compat system call, don't
> consider whether the originating code is IA32 or X32, just allocate from
> a safe region for both, beyond the redzone.  This should be safe for
> IA32, and has the benefit of avoiding TIF_IA32, which we want to drop.

This doesn't look wrong, by why bother (maybe Ccing me on the whole
seris as you always should instead of sending annoying out of context
single patches would have told..).

We will hopefully kill off compat_alloc_user_space in the next few
merge windows..