linux-kernel - Re: [PATCH] pinctrl: rockchip: depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYYtZRuuBpYpPCw1Dkpqr-53MgayebT-D2aZkbDUX1d-Q@mail.gmail.com>
Date:   Sat, 12 Sep 2020 13:21:47 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Jianqun Xu <jay.xu@...k-chips.com>,
        kbuild test robot <lkp@...el.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
Subject: Re: [PATCH] pinctrl: rockchip: depend on OF

On Sat, Sep 5, 2020 at 11:50 PM Heiko Stuebner <heiko@...ech.de> wrote:

> From: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
>
> The Rockchip pinctrl driver needs to handle information from Devicetree
> so only makes sense getting compiled on systems with CONFIG_OF enabled.
>
> This also fixes a problem found by the "kernel-test-robot" when compiling
> the driver on test-builds that do not have CONFIG_OF enabled:
>
>   drivers/pinctrl/pinctrl-rockchip.c: In function 'rockchip_pinctrl_parse_groups':
> >> drivers/pinctrl/pinctrl-rockchip.c:2881:9: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
>     2881 |   ret = pinconf_generic_parse_dt_config(np_config, NULL,
>          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |         pinconf_generic_dump_config
>    drivers/pinctrl/pinctrl-rockchip.c: In function 'rockchip_gpiolib_register':
> >> drivers/pinctrl/pinctrl-rockchip.c:3473:5: error: 'struct gpio_chip' has no member named 'of_node'
>     3473 |   gc->of_node = bank->of_node;
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>

Patch applied.

Yours,
Linus Walleij