linux-kernel - Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFCwf12kfQJk5XwcX7qRRC-oLfXAUr+DSdBv0X9RcEDpyxJirA@mail.gmail.com>
Date:   Sat, 12 Sep 2020 18:19:50 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org, SW_Drivers <SW_Drivers@...ana.ai>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Omer Shpigelman <oshpigelman@...ana.ai>
Subject: Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC
 control operations

On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Hi,
>
> On 9/12/20 7:41 AM, Oded Gabbay wrote:
> > +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
>
>
> ioctl numbers ('H') should be documented in
> Documentation/userspace-api/ioctl/ioctl-number.rst
>
> Sorry if I missed seeing that. (I scanned quickly.)
>
> thanks.
>
> --
> ~Randy
>

Hi Randy,
It is already documented for some time now:

'H'   00-0F  uapi/misc/habanalabs.h                                  conflict!

I think you commented on this a few releases ago and I added it then :)

Thanks,
Oded