lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Sep 2020 18:09:45 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Martin DEVERA <devik@...labs.cz> Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: pinctrl: sx150x bug On Wed, Aug 5, 2020 at 11:28 AM Martin DEVERA <devik@...labs.cz> wrote: > I encountered bug in SX1502 expander driver in 5.7.7. Here is relevant > DTS part: > > compatible = "semtech,sx1502q"; > gpio4_cfg_pins: gpio2-cfg { > pins = "gpio5"; > output-high; > }; > > And part of OOPS: > > [ 0.673996] [<c023cfa6>] (gpiochip_get_data) from [<c023b235>] > (sx150x_gpio_direction_output+0xd) > [ 0.683259] [<c023b235>] (sx150x_gpio_direction_output) from > [<c023b363>] (sx150x_pinconf_set+0x) > [ 0.692796] [<c023b363>] (sx150x_pinconf_set) from [<c0238fef>] > (pinconf_apply_setting+0x39/0x7e) > [ 0.701635] [<c0238fef>] (pinconf_apply_setting) from [<c0236c77>] > (pinctrl_commit_state+0xa5/0x) > [ 0.710648] [<c0236c77>] (pinctrl_commit_state) from [<c0237e03>] > (pinctrl_enable+0xff/0x1d4) > [ 0.719139] [<c0237e03>] (pinctrl_enable) from [<c023b791>] > (sx150x_probe+0x1a3/0x358) > [ 0.727027] [<c023b791>] (sx150x_probe) from [<c02c38bf>] > (i2c_device_probe+0x1bb/0x1dc) > > The problem is that sx150x_pinconf_set uses sx150x_gpio_direction_output > but gpio is not > setup yet. Patch below fixes it but I'm not sure whether is it correct: I simply rebased and applied this patch now. Yours, Linus Walleij
Powered by blists - more mailing lists