linux-kernel - Re: [PATCH v3 0/4] Fixes for setting event freq/periods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200912204902.GE1714160@krava>
Date:   Sat, 12 Sep 2020 22:49:02 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v3 0/4] Fixes for setting event freq/periods

On Fri, Sep 11, 2020 at 07:56:51PM -0700, Ian Rogers wrote:
> Some fixes that address issues for regular and pfm4 events with 2
> additional perf_event_attr tests. Various authors, David Sharp isn't
> currently at Google.
> 
> v3. moved a loop into a helper following Adrian Hunter's suggestion. 
> v2. corrects the commit message following Athira Rajeev's suggestion.
> 
> David Sharp (1):
>   perf record: Set PERF_RECORD_PERIOD if attr->freq is set.
> 
> Ian Rogers (2):
>   perf record: Don't clear event's period if set by a term
>   perf test: Leader sampling shouldn't clear sample period
> 
> Stephane Eranian (1):
>   perf record: Prevent override of attr->sample_period for libpfm4
>     events

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> 
>  tools/perf/tests/attr/README             |  1 +
>  tools/perf/tests/attr/test-record-group2 | 29 ++++++++++++++++++++
>  tools/perf/util/evsel.c                  | 10 ++++---
>  tools/perf/util/record.c                 | 34 ++++++++++++++++++------
>  4 files changed, 63 insertions(+), 11 deletions(-)
>  create mode 100644 tools/perf/tests/attr/test-record-group2
> 
> -- 
> 2.28.0.618.gf4bc123cb7-goog
>