linux-kernel - Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9ae6d3d-e616-58c5-5db5-149fb702631f@redhat.com>
Date:   Sat, 12 Sep 2020 08:20:14 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Wanpeng Li <kernellwp@...il.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        "Paul K ." <kronenpj@...nenpj.dyndns.org>
Subject: Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into
 svm_vcpu_run()

On 09/09/20 10:47, Wanpeng Li wrote:
>> One more thing:
>>
>> VMX version does
>>
>>         vmx_complete_interrupts(vmx);
>>         if (is_guest_mode(vcpu))
>>                 return EXIT_FASTPATH_NONE;
>>
>> and on SVM we analyze is_guest_mode() inside
>> svm_exit_handlers_fastpath() - should we also change that for
>> conformity?
> 
> Agreed, will do in v2.

Please just send an incremental patch.  Thanks!

Paolo